refactor(timezone): checkTime in dnode and mnode implementations and timetruncate logic for interval (3.3.6 branch) by Tony2h · Pull Request #35058 · taosdata/TDengine

Tony2h · 2026-04-03T07:34:56Z

Description

Issue(s)

Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

Is the user manual updated?
Are the test cases passed and automated?
Is there no significant decrease in test coverage?

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 11 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-08T02:45:19Z

    return ts;
  }

+  int32_t code = 0;


int32_t code = 0; in taosTimeTruncate is unused, which will trigger -Wunused-variable warnings (and may fail the build if warnings are treated as errors). Remove it or use it for actual error propagation.

Suggested change

int32_t code = 0;

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

… accurate DST handling

…ieval logic in mnode

…cal bug related to timezone offset retrieval

… in dmSendStatusReq

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

error handling in mndGetCurrentTimezoneCheckTime [skip ci]

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…DST transition issues

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…tAtTicks function

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…s with improved caching mechanism

dapan1121

LGTM

Tony2h requested review from dapan1121 and guanshengliang as code owners April 3, 2026 07:34

Copilot AI review requested due to automatic review settings April 3, 2026 07:34

taosdata-bot bot added the team engine label Apr 3, 2026

Copilot started reviewing on behalf of Tony2h April 3, 2026 07:35 View session

This comment was marked as outdated.

Sign in to view

Copilot AI review requested due to automatic review settings April 8, 2026 02:38

Copilot started reviewing on behalf of Tony2h April 8, 2026 02:38 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings April 9, 2026 01:14

Copilot started reviewing on behalf of Tony2h April 9, 2026 01:14 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

Tony2h changed the title ~~refactor(timezone): standardize checkTime initialization to 0 across dnode and mnode implementations~~ refactor(timezone): checkTime in dnode and mnode implementations and timetruncate logic for interval Apr 9, 2026

Tony2h changed the title ~~refactor(timezone): checkTime in dnode and mnode implementations and timetruncate logic for interval~~ refactor(timezone): checkTime in dnode and mnode implementations and timetruncate logic for interval (3.3.6 branch) Apr 9, 2026

Copilot AI review requested due to automatic review settings April 9, 2026 06:56

Tony2h requested a review from zitsen as a code owner April 9, 2026 06:56

Copilot started reviewing on behalf of Tony2h April 9, 2026 06:57 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

Comment thread source/common/test/commonTests.cpp

Comment thread source/common/test/commonTests.cpp

Comment thread source/dnode/mnode/impl/src/mndDnode.c Outdated

taosdata deleted a comment from Copilot AI Apr 10, 2026

taosdata deleted a comment from gemini-code-assist bot Apr 10, 2026

taosdata deleted a comment from Copilot AI Apr 10, 2026

Tony2h added 6 commits April 10, 2026 14:16

fix(timezone): adjust truncation logic in truncateToLocalMidnight for…

99ecfaf

… accurate DST handling

fix(timezone): remove checkTime field and update timezone offset retr…

92e389c

…ieval logic in mnode

fix(timezone): compile error in mndGetCurrentTimezoneCheckTime

ce45e37

fix(timezone): update comment for taosTimeTruncate to clarify histori…

f0f0dbf

…cal bug related to timezone offset retrieval

fix(timezone): update interval test data for accurate timezone handling

150e786

fix(timezone): add error handling for local timezone offset retrieval…

2ebc6a5

… in dmSendStatusReq

Copilot AI review requested due to automatic review settings April 10, 2026 06:16

Tony2h force-pushed the fix/3.3.6/tz branch from 51aedde to 2ebc6a5 Compare April 10, 2026 06:16

Copilot started reviewing on behalf of Tony2h April 10, 2026 06:17 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Comment thread source/dnode/mgmt/mgmt_dnode/src/dmHandle.c

Comment thread source/os/src/osTimezone.c Outdated

Tony2h added 3 commits April 10, 2026 15:08

fix(timezone): remove unused taosGetTZOffsetSeconds function and improve

e8fef71

error handling in mndGetCurrentTimezoneCheckTime [skip ci]

chore(ci): trigger pipeline

27e4909

fix(timezone): compile on mac

ab038d4

Copilot AI review requested due to automatic review settings April 13, 2026 07:23

Copilot started reviewing on behalf of Tony2h April 13, 2026 07:24 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Comment thread source/dnode/mnode/impl/src/mndDnode.c Outdated

Comment thread source/dnode/mgmt/mgmt_dnode/src/dmHandle.c

Tony2h added 2 commits April 14, 2026 14:12

fix(timezone): improve timezone offset handling and caching to avoid …

ed8b305

…DST transition issues

fix(timezone): improve error handling in timezone offset retrieval

cfb77ab

Copilot AI review requested due to automatic review settings April 14, 2026 07:21

Copilot started reviewing on behalf of Tony2h April 14, 2026 07:22 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Comment thread source/common/src/ttime.c Outdated

Comment thread source/common/src/ttime.c Outdated

Comment thread source/dnode/mnode/impl/src/mndDnode.c Outdated

Comment thread source/common/test/commonTests.cpp

fix(timezone): simplify timezone offset retrieval logic in getTZOffse…

9b4ab41

…tAtTicks function

Copilot AI review requested due to automatic review settings April 14, 2026 10:07

Copilot started reviewing on behalf of Tony2h April 14, 2026 10:07 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Comment thread source/dnode/mnode/impl/src/mndDnode.c Outdated

Comment thread source/common/src/ttime.c

Comment thread source/common/test/commonTests.cpp

fix(timezone): enhance timezone offset handling during DST transition…

57154ff

…s with improved caching mechanism

Tony2h force-pushed the fix/3.3.6/tz branch from 013fe09 to 57154ff Compare April 15, 2026 01:20

dapan1121 reviewed Apr 15, 2026

View reviewed changes

guanshengliang approved these changes Apr 15, 2026

View reviewed changes

guanshengliang merged commit 175850f into 3.3.6 Apr 15, 2026
18 of 22 checks passed

Conversation

Tony2h commented Apr 3, 2026

Description

Issue(s)

Checklist

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dapan1121 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants